Add tracing sqlite db file support so we can connect from python #807
+624
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-pytorch#782) Summary: Add a new otel reader type `InMemoryReader` * impls `ManualReader` and stores global ManualReader instance so we can get metrics during hyperactor program runs. * provides getters to cumulative counters. Will add more metrics later *‼️ Uses cumulative temporality so metrics are stored in the SDK rather than in hyperactor. This might be something we iterate on if collection and transforming to a hashmap each time is too costly * also changes macros in lib.rs to use $crate eliothedeman Reviewed By: eliothedeman Differential Revision: D79658641
Summary: New tracer subscriber to be used for testing (e.g., script or simulator) 1. New logging layer for use in tests that writes all log messages to a series of sqlite tables 2. Add capability to do sql based assertions for script tests or simulation tests 3. New trace level logging events on actor lifecycle events Next diffs will: * Get this working for our PAFT simulator tests so we can easily assert * Support custom columns Differential Revision: D73512355
Summary: POC of Rust-create sqlite db accessable from native python sqlite connection. This allows us to write python tests that test Monarch and assert user (or BE) events using sql queries. * Uses reloadable layer to inject SqliteLayer into tracing registry on demand. * Exposes `with_tracing_db_file` to python to create and get the DB file name so we can connect to Differential Revision: D79761474
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79761474 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
POC of Rust-create sqlite db accessable from native python sqlite connection. This allows us to write python tests that test Monarch and assert user (or BE) events using sql queries.
with_tracing_db_fileto python to create and get the DB file name so we can connect toDifferential Revision: D79761474