De-future spawning actors #813
Open
+208
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit switches actor spawning to no longer return a Future. ActorMesh becomes a DeprecatedNotAFuture to keep existing code working. The implementation delays the send part of endpoints until the actor has spawned. I expect this to have some performance impact, which needs to be measured before we land this. However, this implementation is not what we expect to actually use: the ability to spawn actors/return a ref immediately will be made part of the rust runtime where the overhead will be substantially less. Differential Revision: [D79938417](https://our.internmc.facebook.com/intern/diff/D79938417/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79938417/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Aug 9, 2025
This commit switches actor spawning to no longer return a Future. ActorMesh becomes a DeprecatedNotAFuture to keep existing code working. The implementation delays the send part of endpoints until the actor has spawned. I expect this to have some performance impact, which needs to be measured before we land this. However, this implementation is not what we expect to actually use: the ability to spawn actors/return a ref immediately will be made part of the rust runtime where the overhead will be substantially less. Differential Revision: [D79938417](https://our.internmc.facebook.com/intern/diff/D79938417/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79938417/)! ghstack-source-id: 301854490 Pull Request resolved: #813
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79938417 |
This commit switches actor spawning to no longer return a Future. ActorMesh becomes a DeprecatedNotAFuture to keep existing code working. The implementation delays the send part of endpoints until the actor has spawned. I expect this to have some performance impact, which needs to be measured before we land this. However, this implementation is not what we expect to actually use: the ability to spawn actors/return a ref immediately will be made part of the rust runtime where the overhead will be substantially less. Differential Revision: [D79938417](https://our.internmc.facebook.com/intern/diff/D79938417/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79938417/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Aug 11, 2025
Pull Request resolved: #813 This commit switches actor spawning to no longer return a Future. ActorMesh becomes a DeprecatedNotAFuture to keep existing code working. The implementation delays the send part of endpoints until the actor has spawned. I expect this to have some performance impact, which needs to be measured before we land this. However, this implementation is not what we expect to actually use: the ability to spawn actors/return a ref immediately will be made part of the rust runtime where the overhead will be substantially less. ghstack-source-id: 302149553 @exported-using-ghexport Differential Revision: [D79938417](https://our.internmc.facebook.com/intern/diff/D79938417/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79938417/)!
|
This pull request was exported from Phabricator. Differential Revision: D79938417 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This commit switches actor spawning to no longer return a Future. ActorMesh becomes a DeprecatedNotAFuture to keep existing code working.
The implementation delays the send part of endpoints until the actor has spawned. I expect this to have some performance impact, which needs to be measured before we land this.
However, this implementation is not what we expect to actually use: the ability to spawn actors/return a ref immediately will be made part of the rust runtime where the overhead will be substantially less.
Differential Revision: D79938417
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!