[3.10+][1/n] Add conditional archiving for libmpdec module #106
[3.10+][1/n] Add conditional archiving for libmpdec module #106anirbanr-fb-r2p wants to merge 15 commits intometa-pytorch:mainfrom
Conversation
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
facebook-github-bot
added
the
CLA Signed
|
@anirbanr-fb-r2p has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov Report
@@ Coverage Diff @@
## main #106 +/- ##
==========================================
- Coverage 88.94% 88.86% -0.09%
==========================================
Files 65 65
Lines 3862 3869 +7
==========================================
+ Hits 3435 3438 +3
- Misses 427 431 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
[3.10+][1/n] Add conditional archiving for libmpdec module
|
Seems changes from prev PR got picked up. |
|
@anirbanr-fb-r2p has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@anirbanr-fb-r2p has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| SET(PYTHON_STDLIB "${PYTHON_INSTALL_DIR}/lib/libpython_stdlib3.8.a") | ||
| SET(PYTHON_STDLIB "${PYTHON_INSTALL_DIR}/lib/libpython_stdlib{CPYTHON_VERSION}.a") | ||
|
|
||
| if(${CPYTHON_VERSION} MATCHES "3\.[8-9]") |
There was a problem hiding this comment.
I feel like later on versioning updates to python might be annoying, it may be a good idea to document the process or turn this logic into a function to make the process a bit easier. Otherwise, lgtm.
PaliC
left a comment
PaliC
left a comment
There was a problem hiding this comment.
lgtm barring CI failures which should be addressed before pushing ofc :)
PaliC
left a comment
PaliC
left a comment
There was a problem hiding this comment.
lgtm barring CI failures which should be addressed before pushing ofc :)
|
@anirbanr-fb-r2p has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
|
@anirbanr-fb-r2p has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
|
Hi @anirbanr-fb-r2p! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
3 participants
Cpython has had some changes from v3.10 onwards, for example https://fburl.com/diffing/lrcq4gej .
We want to add some conditional inclusions to multipy cmake to support these changes.
Step 1/n : Replace the removed _decimal/libmpdec/memory.o with _decimal/libmpdec/mpalloc.o.