Give MAST jobs a more descriptive name based on the name of the config being launched #544
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #544 +/- ##
==========================================
- Coverage 84.60% 84.10% -0.51%
==========================================
Files 30 29 -1
Lines 3807 3687 -120
==========================================
- Hits 3221 3101 -120
Misses 586 586 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
casteryh
reviewed
Nov 10, 2025
.meta/mast/launch.sh
Outdated
| USER=$(whoami) | ||
| # Generate a unique job name based on the config file name | ||
| BASENAME=$(basename "$CONFIG_FILE" .yaml) | ||
| BASENAME=${BASENAME#.meta/mast/} |
Contributor
There was a problem hiding this comment.
Suggested change
| BASENAME=${BASENAME#.meta/mast/} |
We shouldn't need this? the output of basename should already be something like qwen_32b.
casteryh
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to tell what a MAST job is running.
Before, MAST jobs looked like:
daniellepintz-forge-tw3pdnAfter, they look like:
https://www.internalfb.com/mlhub/pipelines/runs/mast/qwen3_32b_mast-ugj9cm