feat: add planning result logging (#4022)#4022
Closed
ahmed-shuaibi wants to merge 2 commits into
Closed
Conversation
Summary: Add NONE value to OptimizationTechnique enum so general planner events can indicate no specific technique is active. Differential Revision: D99529682
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@ahmed-shuaibi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97581563. |
ahmed-shuaibi
pushed a commit
to ahmed-shuaibi/torchrec
that referenced
this pull request
Apr 6, 2026
Summary: Log planning SUCCEEDED/FAILED to `training_optimization_events` Scuba table from both `EmbeddingShardingPlanner` and `LinearProgrammingPlanner`. Differential Revision: D97581563
ahmed-shuaibi
pushed a commit
to ahmed-shuaibi/torchrec
that referenced
this pull request
Apr 6, 2026
Summary: Log planning SUCCEEDED/FAILED to `training_optimization_events` Scuba table from both `EmbeddingShardingPlanner` and `LinearProgrammingPlanner`. Differential Revision: D97581563
meta-codesync
Bot
changed the title
ahmed-shuaibi
pushed a commit
to ahmed-shuaibi/torchrec
that referenced
this pull request
Apr 6, 2026
Summary: Log planning SUCCEEDED/FAILED to `training_optimization_events` Scuba table from both `EmbeddingShardingPlanner` and `LinearProgrammingPlanner`. Differential Revision: D97581563
ahmed-shuaibi
force-pushed
the
export-D97581563
branch
from
1a280b7 to
6495545
Compare
ahmed-shuaibi
pushed a commit
to ahmed-shuaibi/torchrec
that referenced
this pull request
Apr 6, 2026
Summary: Log planning SUCCEEDED/FAILED to `training_optimization_events` Scuba table from both `EmbeddingShardingPlanner` and `LinearProgrammingPlanner`. Differential Revision: D97581563
ahmed-shuaibi
pushed a commit
to ahmed-shuaibi/torchrec
that referenced
this pull request
Apr 6, 2026
Summary: Log planning SUCCEEDED/FAILED to `training_optimization_events` Scuba table from both `EmbeddingShardingPlanner` and `LinearProgrammingPlanner`. Differential Revision: D97581563
ahmed-shuaibi
pushed a commit
to ahmed-shuaibi/torchrec
that referenced
this pull request
Apr 6, 2026
Summary: Log planning SUCCEEDED/FAILED to `training_optimization_events` Scuba table from both `EmbeddingShardingPlanner` and `LinearProgrammingPlanner`. Differential Revision: D97581563
ahmed-shuaibi
pushed a commit
to ahmed-shuaibi/torchrec
that referenced
this pull request
Apr 6, 2026
Summary: Pull Request resolved: meta-pytorch#4022 Pull Request resolved: meta-pytorch#4010 Log planning SUCCEEDED/FAILED to `training_optimization_events` Scuba table from both `EmbeddingShardingPlanner` and `LinearProgrammingPlanner`. Differential Revision: D97581563
ahmed-shuaibi
force-pushed
the
export-D97581563
branch
from
6495545 to
c62b0f5
Compare
ahmed-shuaibi
pushed a commit
to ahmed-shuaibi/torchrec
that referenced
this pull request
Apr 6, 2026
Summary: Log planning SUCCEEDED/FAILED to `training_optimization_events` Scuba table from both `EmbeddingShardingPlanner` and `LinearProgrammingPlanner`. Differential Revision: D97581563
ahmed-shuaibi
pushed a commit
to ahmed-shuaibi/torchrec
that referenced
this pull request
Apr 6, 2026
Summary: Log planning SUCCEEDED/FAILED to `training_optimization_events` Scuba table from both `EmbeddingShardingPlanner` and `LinearProgrammingPlanner`. Differential Revision: D97581563
ahmed-shuaibi
pushed a commit
to ahmed-shuaibi/torchrec
that referenced
this pull request
Apr 6, 2026
Summary: Log planning SUCCEEDED/FAILED to `training_optimization_events` Scuba table from both `EmbeddingShardingPlanner` and `LinearProgrammingPlanner`. Differential Revision: D97581563
ahmed-shuaibi
pushed a commit
to ahmed-shuaibi/torchrec
that referenced
this pull request
Apr 6, 2026
Summary: Log planning SUCCEEDED/FAILED to `training_optimization_events` Scuba table from both `EmbeddingShardingPlanner` and `LinearProgrammingPlanner`. Differential Revision: D97581563
ahmed-shuaibi
pushed a commit
to ahmed-shuaibi/torchrec
that referenced
this pull request
Apr 6, 2026
Summary: Log planning SUCCEEDED/FAILED to `training_optimization_events` Scuba table from both `EmbeddingShardingPlanner` and `LinearProgrammingPlanner`. Differential Revision: D97581563
ahmed-shuaibi
pushed a commit
to ahmed-shuaibi/torchrec
that referenced
this pull request
Apr 6, 2026
Summary: Log planning SUCCEEDED/FAILED to `training_optimization_events` Scuba table from both `EmbeddingShardingPlanner` and `LinearProgrammingPlanner`. Reviewed By: hammad45 Differential Revision: D97581563
ahmed-shuaibi
pushed a commit
to ahmed-shuaibi/torchrec
that referenced
this pull request
Apr 6, 2026
Summary: Log planning SUCCEEDED/FAILED to `training_optimization_events` Scuba table from both `EmbeddingShardingPlanner` and `LinearProgrammingPlanner`. Reviewed By: hammad45 Differential Revision: D97581563
ahmed-shuaibi
pushed a commit
to ahmed-shuaibi/torchrec
that referenced
this pull request
Apr 6, 2026
Summary: Log planning SUCCEEDED/FAILED to `training_optimization_events` Scuba table from both `EmbeddingShardingPlanner` and `LinearProgrammingPlanner`. Reviewed By: hammad45 Differential Revision: D97581563
ahmed-shuaibi
force-pushed
the
export-D97581563
branch
from
c62b0f5 to
3f298d6
Compare
Summary: Pull Request resolved: meta-pytorch#4022 Log planning SUCCEEDED/FAILED to `training_optimization_events` Scuba table from both `EmbeddingShardingPlanner` and `LinearProgrammingPlanner`. Reviewed By: hammad45 Differential Revision: D97581563
ahmed-shuaibi
force-pushed
the
export-D97581563
branch
from
3f298d6 to
f39c096
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Log planning SUCCEEDED/FAILED to
training_optimization_eventsScuba table from bothEmbeddingShardingPlannerandLinearProgrammingPlanner.Reviewed By: hammad45
Differential Revision: D97581563