Fix Torchrec repackaging compatiblity issues.#4141
Closed
nipung90 wants to merge 1 commit intometa-pytorch:mainfrom
Closed
Fix Torchrec repackaging compatiblity issues.#4141nipung90 wants to merge 1 commit intometa-pytorch:mainfrom
nipung90 wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
Summary: Previous torchrec changes will break model publish on certain models with distributed_transform enabled, these changes slipped through because the repackaging models were outdated. It caused S650452. This diff adds try catch block on the import of such modules. Differential Revision: D101693348
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@nipung90 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101693348. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Previous torchrec changes will break model publish on certain models with distributed_transform enabled, these changes slipped through because the repackaging models were outdated.
It caused S650452.
This diff adds try catch block on the import of such modules.
Differential Revision: D101693348