Create Reduce-Scatter Primitive Benchmark (#4483) - #4483
Closed
siqihuang wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@siqihuang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113960618. |
meta-codesync
Bot
changed the title
siqihuang
pushed a commit
to siqihuang/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: This diff introduces a new benchmark for evaluating the performance of the reduce-scatter collective in the `PooledEmbeddingsReduceScatter` module from `dist_data.py`. The benchmark is integrated with the existing `benchmark_primitive.py` file. The goal is to measure the reduce-scatter performance and analyze its impact on the overall efficiency of the `output_dist` process. ### Key Changes: * Updated `benchmark_primitive.py` to include the reduce-scatter benchmark. * Added comments to explain the newly added benchmark in the context of `PooledEmbeddingsReduceScatter` and its usage in `output_dist`. Differential Revision: D113960618
siqihuang
force-pushed
the
export-D113960618
branch
from
August 5, 2026 18:24
6cf5187 to
183111e
Compare
Summary: This diff introduces a new benchmark for evaluating the performance of the reduce-scatter collective in the `PooledEmbeddingsReduceScatter` module from `dist_data.py`. The benchmark is integrated with the existing `benchmark_primitive.py` file. The goal is to measure the reduce-scatter performance and analyze its impact on the overall efficiency of the `output_dist` process. ### Key Changes: * Updated `benchmark_primitive.py` to include the reduce-scatter benchmark. * Added comments to explain the newly added benchmark in the context of `PooledEmbeddingsReduceScatter` and its usage in `output_dist`. Reviewed By: TroyGarden Differential Revision: D113960618
siqihuang
force-pushed
the
export-D113960618
branch
from
August 6, 2026 16:59
183111e to
eeb5859
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff introduces a new benchmark for evaluating the performance of the reduce-scatter collective in the
PooledEmbeddingsReduceScattermodule fromdist_data.py.The benchmark is integrated with the existing
benchmark_primitive.pyfile.The goal is to measure the reduce-scatter performance and analyze its impact on the overall efficiency of the
output_distprocess.Key Changes:
benchmark_primitive.pyto include the reduce-scatter benchmark.PooledEmbeddingsReduceScatterand its usage inoutput_dist.Reviewed By: TroyGarden
Differential Revision: D113960618