Select CUDA v2 bounds checking for Triton TBE (#4484) - #4484
Closed
stashuk-olek wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@stashuk-olek has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114279989. |
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
meta-codesync
Bot
changed the title
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
force-pushed
the
export-D114279989
branch
from
August 5, 2026 18:00
4cff289 to
5625960
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
force-pushed
the
export-D114279989
branch
from
August 5, 2026 21:00
5625960 to
64235fc
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
force-pushed
the
export-D114279989
branch
from
August 6, 2026 16:18
64235fc to
c139569
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
force-pushed
the
export-D114279989
branch
from
August 6, 2026 20:13
d0ca14c to
f5490f5
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
force-pushed
the
export-D114279989
branch
from
August 6, 2026 23:04
f5490f5 to
3622d25
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Cuda wasn't using bounds check, but triton did. Match the both to make it fair comparison Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
meta-codesync
Bot
changed the title
stashuk-olek
force-pushed
the
export-D114279989
branch
from
August 7, 2026 17:42
3622d25 to
fdc8e3f
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Use BoundsCheckMode.V2 for Triton TBE standalone index validation. This preserves the existing warning and offset-repair behavior while reducing validation overhead before Triton forward. Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Use BoundsCheckMode.V2 for Triton TBE standalone index validation. This preserves the existing warning and offset-repair behavior while reducing validation overhead before Triton forward. Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
Summary: Use BoundsCheckMode.V2 for Triton TBE standalone index validation. This preserves the existing warning and offset-repair behavior while reducing validation overhead before Triton forward. Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Use BoundsCheckMode.V2 for Triton TBE standalone index validation. This preserves the existing warning and offset-repair behavior while reducing validation overhead before Triton forward. Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Use BoundsCheckMode.V2 for Triton TBE standalone index validation. This preserves the existing warning and offset-repair behavior while reducing validation overhead before Triton forward. Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Use BoundsCheckMode.V2 for Triton TBE standalone index validation. This preserves the existing warning and offset-repair behavior while reducing validation overhead before Triton forward. Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
meta-codesync
Bot
changed the title
stashuk-olek
force-pushed
the
export-D114279989
branch
from
August 8, 2026 06:14
fdc8e3f to
65e1445
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Use BoundsCheckMode.V2 for Triton TBE standalone index validation. This preserves the existing warning and offset-repair behavior while reducing validation overhead before Triton forward. Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Use BoundsCheckMode.V2 for Triton TBE standalone index validation. This preserves the existing warning and offset-repair behavior while reducing validation overhead before Triton forward. Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Use BoundsCheckMode.V2 for Triton TBE standalone index validation. This preserves the existing warning and offset-repair behavior while reducing validation overhead before Triton forward. Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Use BoundsCheckMode.V2 for Triton TBE standalone index validation. This preserves the existing warning and offset-repair behavior while reducing validation overhead before Triton forward.
Reviewed By: axeisghost, TroyGarden
Differential Revision: D114279989