Fuse Triton TBE forward bounds checking (#4485) - #4485
Closed
stashuk-olek wants to merge 2 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@stashuk-olek has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114284802. |
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
meta-codesync
Bot
changed the title
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
force-pushed
the
export-D114284802
branch
from
August 5, 2026 18:00
82215e8 to
e954795
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
force-pushed
the
export-D114284802
branch
from
August 5, 2026 21:01
e954795 to
abb3f2c
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
force-pushed
the
export-D114284802
branch
from
August 6, 2026 16:18
abb3f2c to
a2cead4
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
force-pushed
the
export-D114284802
branch
2 times, most recently
from
August 6, 2026 23:03
6ac5661 to
6840aee
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Now that both of cuda/triton does it bounds check, we fuse that to avoid traffic. Adding as an option Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
meta-codesync
Bot
changed the title
stashuk-olek
force-pushed
the
export-D114284802
branch
from
August 7, 2026 17:41
6840aee to
570d817
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 7, 2026
Summary: Validate and repair indices inside supported unweighted, non-VBE Triton forward kernels. Unsupported configurations retain the CUDA v2 fallback, while fused checked loads preserve warning accumulation without a separate full-index pass. Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 7, 2026
Summary: Validate and repair indices inside supported unweighted, non-VBE Triton forward kernels. Unsupported configurations retain the CUDA v2 fallback, while fused checked loads preserve warning accumulation without a separate full-index pass. Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 7, 2026
Summary: Validate and repair indices inside supported unweighted, non-VBE Triton forward kernels. Unsupported configurations retain the CUDA v2 fallback, while fused checked loads preserve warning accumulation without a separate full-index pass. Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 7, 2026
Summary: Validate and repair indices inside supported unweighted, non-VBE Triton forward kernels. Unsupported configurations retain the CUDA v2 fallback, while fused checked loads preserve warning accumulation without a separate full-index pass. Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 7, 2026
Summary: Validate and repair indices inside supported unweighted, non-VBE Triton forward kernels. Unsupported configurations retain the CUDA v2 fallback, while fused checked loads preserve warning accumulation without a separate full-index pass. Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 7, 2026
Summary: Validate and repair indices inside supported unweighted, non-VBE Triton forward kernels. Unsupported configurations retain the CUDA v2 fallback, while fused checked loads preserve warning accumulation without a separate full-index pass. Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 7, 2026
Summary: Validate and repair indices inside supported unweighted, non-VBE Triton forward kernels. Unsupported configurations retain the CUDA v2 fallback, while fused checked loads preserve warning accumulation without a separate full-index pass. Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
Summary: Use BoundsCheckMode.V2 for Triton TBE standalone index validation. This preserves the existing warning and offset-repair behavior while reducing validation overhead before Triton forward. Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
Summary: Validate and repair indices inside supported unweighted, non-VBE Triton forward kernels. Unsupported configurations retain the CUDA v2 fallback, while fused checked loads preserve warning accumulation without a separate full-index pass. Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Validate and repair indices inside supported unweighted, non-VBE Triton forward kernels. Unsupported configurations retain the CUDA v2 fallback, while fused checked loads preserve warning accumulation without a separate full-index pass. Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
meta-codesync
Bot
changed the title
stashuk-olek
force-pushed
the
export-D114284802
branch
from
August 8, 2026 06:14
570d817 to
563f886
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Validate and repair indices inside supported unweighted, non-VBE Triton forward kernels. Unsupported configurations retain the CUDA v2 fallback, while fused checked loads preserve warning accumulation without a separate full-index pass. Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Validate and repair indices inside supported unweighted, non-VBE Triton forward kernels. Unsupported configurations retain the CUDA v2 fallback, while fused checked loads preserve warning accumulation without a separate full-index pass. Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Validate and repair indices inside supported unweighted, non-VBE Triton forward kernels. Unsupported configurations retain the CUDA v2 fallback, while fused checked loads preserve warning accumulation without a separate full-index pass. Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Validate and repair indices inside supported unweighted, non-VBE Triton forward kernels. Unsupported configurations retain the CUDA v2 fallback, while fused checked loads preserve warning accumulation without a separate full-index pass. Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Validate and repair indices inside supported unweighted, non-VBE Triton forward kernels. Unsupported configurations retain the CUDA v2 fallback, while fused checked loads preserve warning accumulation without a separate full-index pass. Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Validate and repair indices inside supported unweighted, non-VBE Triton forward kernels. Unsupported configurations retain the CUDA v2 fallback, while fused checked loads preserve warning accumulation without a separate full-index pass. Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Validate and repair indices inside supported unweighted, non-VBE Triton forward kernels. Unsupported configurations retain the CUDA v2 fallback, while fused checked loads preserve warning accumulation without a separate full-index pass.
Reviewed By: TroyGarden, axeisghost
Differential Revision: D114284802