Reduce Triton TBE backward reduction pressure (#4487) - #4487
Closed
stashuk-olek wants to merge 4 commits into
Closed
Reduce Triton TBE backward reduction pressure (#4487)#4487stashuk-olek wants to merge 4 commits into
stashuk-olek wants to merge 4 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@stashuk-olek has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114273026. |
meta-codesync
Bot
changed the title
stashuk-olek
force-pushed
the
export-D114273026
branch
from
August 5, 2026 17:59
cfdb9a7 to
562c76e
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Tweaking a bit to hide more from critical path. Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Tweaking a bit to hide more from critical path. Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Tweaking a bit to hide more from critical path. Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Tweaking a bit to hide more from critical path. Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Tweaking a bit to hide more from critical path. Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Tweaking a bit to hide more from critical path. Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Tweaking a bit to hide more from critical path. Differential Revision: D114273026
stashuk-olek
force-pushed
the
export-D114273026
branch
from
August 5, 2026 21:00
562c76e to
e1f5b07
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Tweaking a bit to hide more from critical path. Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Tweaking a bit to hide more from critical path. Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Tweaking a bit to hide more from critical path. Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Tweaking a bit to hide more from critical path. Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Tweaking a bit to hide more from critical path. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Tweaking a bit to hide more from critical path. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Tweaking a bit to hide more from critical path. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Tweaking a bit to hide more from critical path. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Tweaking a bit to hide more from critical path. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Tweaking a bit to hide more from critical path. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
force-pushed
the
export-D114273026
branch
2 times, most recently
from
August 6, 2026 20:10
0f998cf to
ac5dcff
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Tweaking a bit to hide more from critical path. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Tweaking a bit to hide more from critical path. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Tweaking a bit to hide more from critical path. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Tweaking a bit to hide more from critical path. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
force-pushed
the
export-D114273026
branch
from
August 6, 2026 20:10
ac5dcff to
7b897ac
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Tweaking a bit to hide more from critical path. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Tweaking a bit to hide more from critical path. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Tweaking a bit to hide more from critical path. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Tweaking a bit to hide more from critical path. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
force-pushed
the
export-D114273026
branch
from
August 6, 2026 20:13
7b897ac to
7aec3d7
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Tweaking a bit to hide more from critical path. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Tweaking a bit to hide more from critical path. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
force-pushed
the
export-D114273026
branch
from
August 6, 2026 23:03
7aec3d7 to
5683b56
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Tweaking a bit to hide more from critical path. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Tweaking a bit to hide more from critical path. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Tweaking a bit to hide more from critical path. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Tweaking a bit to hide more from critical path. Reviewed By: axeisghost Differential Revision: D114273026
meta-codesync
Bot
changed the title
stashuk-olek
force-pushed
the
export-D114273026
branch
from
August 7, 2026 17:42
5683b56 to
5a5874e
Compare
Summary: Use BoundsCheckMode.V2 for Triton TBE standalone index validation. This preserves the existing warning and offset-repair behavior while reducing validation overhead before Triton forward. Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
Summary: Validate and repair indices inside supported unweighted, non-VBE Triton forward kernels. Unsupported configurations retain the CUDA v2 fallback, while fused checked loads preserve warning accumulation without a separate full-index pass. Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
Summary: Restructure short- and long-run gradient accumulation to reduce serialized reduction pressure. The new reduction schedule exposes more independent work while preserving the existing exact rowwise optimizer update. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Restructure short- and long-run gradient accumulation to reduce serialized reduction pressure. The new reduction schedule exposes more independent work while preserving the existing exact rowwise optimizer update. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Restructure short- and long-run gradient accumulation to reduce serialized reduction pressure. The new reduction schedule exposes more independent work while preserving the existing exact rowwise optimizer update. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Restructure short- and long-run gradient accumulation to reduce serialized reduction pressure. The new reduction schedule exposes more independent work while preserving the existing exact rowwise optimizer update. Reviewed By: axeisghost Differential Revision: D114273026
meta-codesync
Bot
changed the title
stashuk-olek
force-pushed
the
export-D114273026
branch
from
August 8, 2026 06:14
5a5874e to
4ebe608
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Restructure short- and long-run gradient accumulation to reduce serialized reduction pressure. The new reduction schedule exposes more independent work while preserving the existing exact rowwise optimizer update. Reviewed By: axeisghost Differential Revision: D114273026
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Restructure short- and long-run gradient accumulation to reduce serialized reduction pressure. The new reduction schedule exposes more independent work while preserving the existing exact rowwise optimizer update. Reviewed By: axeisghost Differential Revision: D114273026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Restructure short- and long-run gradient accumulation to reduce serialized reduction pressure. The new reduction schedule exposes more independent work while preserving the existing exact rowwise optimizer update.
Reviewed By: axeisghost
Differential Revision: D114273026