Widen Triton TBE forward gather issue (#4490) - #4490
Closed
stashuk-olek wants to merge 7 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@stashuk-olek has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114280947. |
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Small tweak as well, a bit more unroll. Reviewed By: axeisghost Differential Revision: D114280947
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Small tweak as well, a bit more unroll. Reviewed By: axeisghost Differential Revision: D114280947
meta-codesync
Bot
changed the title
stashuk-olek
force-pushed
the
export-D114280947
branch
from
August 5, 2026 18:01
315c9c5 to
15de261
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Small tweak as well, a bit more unroll. Reviewed By: axeisghost Differential Revision: D114280947
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Small tweak as well, a bit more unroll. Reviewed By: axeisghost Differential Revision: D114280947
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 5, 2026
Summary: Small tweak as well, a bit more unroll. Reviewed By: axeisghost Differential Revision: D114280947
stashuk-olek
force-pushed
the
export-D114280947
branch
2 times, most recently
from
August 6, 2026 16:18
fd0fa01 to
5d0ba15
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Small tweak as well, a bit more unroll. Reviewed By: axeisghost Differential Revision: D114280947
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Small tweak as well, a bit more unroll. Reviewed By: axeisghost Differential Revision: D114280947
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Small tweak as well, a bit more unroll. Reviewed By: axeisghost Differential Revision: D114280947
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Small tweak as well, a bit more unroll. Reviewed By: axeisghost Differential Revision: D114280947
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Small tweak as well, a bit more unroll. Reviewed By: axeisghost Differential Revision: D114280947
stashuk-olek
force-pushed
the
export-D114280947
branch
2 times, most recently
from
August 6, 2026 20:11
da9622f to
2f2900b
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Small tweak as well, a bit more unroll. Reviewed By: axeisghost Differential Revision: D114280947
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Small tweak as well, a bit more unroll. Reviewed By: axeisghost Differential Revision: D114280947
stashuk-olek
force-pushed
the
export-D114280947
branch
from
August 6, 2026 20:13
2f2900b to
91bd51b
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Small tweak as well, a bit more unroll. Reviewed By: axeisghost Differential Revision: D114280947
stashuk-olek
force-pushed
the
export-D114280947
branch
from
August 6, 2026 23:04
91bd51b to
e297b85
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Small tweak as well, a bit more unroll. Reviewed By: axeisghost Differential Revision: D114280947
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 6, 2026
Summary: Small tweak as well, a bit more unroll. Reviewed By: axeisghost Differential Revision: D114280947
meta-codesync
Bot
changed the title
stashuk-olek
force-pushed
the
export-D114280947
branch
from
August 7, 2026 17:42
e297b85 to
8fa843f
Compare
Summary: Use BoundsCheckMode.V2 for Triton TBE standalone index validation. This preserves the existing warning and offset-repair behavior while reducing validation overhead before Triton forward. Reviewed By: axeisghost, TroyGarden Differential Revision: D114279989
Summary: Validate and repair indices inside supported unweighted, non-VBE Triton forward kernels. Unsupported configurations retain the CUDA v2 fallback, while fused checked loads preserve warning accumulation without a separate full-index pass. Reviewed By: TroyGarden, axeisghost Differential Revision: D114284802
Summary: Restructure short- and long-run gradient accumulation to reduce serialized reduction pressure. The new reduction schedule exposes more independent work while preserving the existing exact rowwise optimizer update. Reviewed By: axeisghost Differential Revision: D114273026
) Summary: Reduce the dout reduction tile from 16 to 8 in the unweighted short-run, separate long-run accumulation, and fused long-run kernels. The smaller tile reduces live vector state and register pressure on B200 while retaining FP32 accumulation and the existing rowwise optimizer update. Weighted kernels remain unchanged. Reviewed By: axeisghost Differential Revision: D114403703
Summary: Process multiple bags per Triton program where the workload has enough parallelism. This amortizes program overhead and exposes independent loads without changing the embedding reduction. Reviewed By: axeisghost Differential Revision: D114280197
Summary: Issue up to eight independent index gathers per loop iteration on profitable long-bag shapes. The wider loop increases memory-level parallelism while retaining the four-wide path for shapes where register pressure dominates. Reviewed By: axeisghost Differential Revision: D114280947
meta-codesync
Bot
changed the title
stashuk-olek
force-pushed
the
export-D114280947
branch
from
August 8, 2026 06:14
8fa843f to
d9882fa
Compare
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Issue up to eight independent index gathers per loop iteration on profitable long-bag shapes. The wider loop increases memory-level parallelism while retaining the four-wide path for shapes where register pressure dominates. Reviewed By: axeisghost Differential Revision: D114280947
stashuk-olek
added a commit
to stashuk-olek/torchrec
that referenced
this pull request
Aug 8, 2026
Summary: Issue up to eight independent index gathers per loop iteration on profitable long-bag shapes. The wider loop increases memory-level parallelism while retaining the four-wide path for shapes where register pressure dominates. Reviewed By: axeisghost Differential Revision: D114280947
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Issue up to eight independent index gathers per loop iteration on profitable long-bag shapes. The wider loop increases memory-level parallelism while retaining the four-wide path for shapes where register pressure dominates.
Reviewed By: axeisghost
Differential Revision: D114280947