Preserve metric construction in offloaded clones (#4582) - #4582
Open
jeffkbkim wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@jeffkbkim has exported this pull request. If you are a Meta employee, you can view the originating Diff in D115919787. |
meta-codesync
Bot
changed the title
jeffkbkim
added a commit
to jeffkbkim/torchrec
that referenced
this pull request
Aug 18, 2026
Summary: Preserve metric-specific construction semantics when creating an offloaded reporting copy. This prevents valid metric options from silently reverting to defaults. Differential Revision: D115919787
jeffkbkim
force-pushed
the
export-D115919787
branch
from
August 18, 2026 21:12
9a24e84 to
fe7b864
Compare
Summary: Preserve metric-specific construction semantics when creating an offloaded reporting copy. This prevents valid metric options from silently reverting to defaults. Reviewed By: TroyGarden Differential Revision: D115919787
jeffkbkim
force-pushed
the
export-D115919787
branch
from
August 19, 2026 16:13
fe7b864 to
831b0a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Preserve metric-specific construction semantics when creating an offloaded reporting copy. This prevents valid metric options from silently reverting to defaults.
Reviewed By: TroyGarden
Differential Revision: D115919787