-
Notifications
You must be signed in to change notification settings - Fork 234
Names and gravatars for authors and contributors can be improved #1270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
the only thing I see presently missing from this plan is "past releasers". Which may or may not be important, but there's presently no obvious way to display that in the metadata if it is desirable. |
@kentfredric The creators of the contributors data should try to take that into account. I think this sounds totally reasonable. |
See also #940. |
- when on MSWin32, check for mysysgit version and also set appropriate config options for proper unicode support - new "order_by" configuration option, to allow sorting contributors by number of commits made, rather than alphabetically - mark "include_releaser" option as experimental, as it will likely get removed if metacpan/metacpan-web#1270 gets resolved
Looks like that site belongs to @tobyink ? |
I don't know that it needs to be so complicated. I don't know that most people understand, know about, or care about the distinction between managers, authors and contributors. It could just say "Karen Etheridge and 4 others". Karen's algorithm seems decent enough for the use this gets. |
@wchristian has previously requested that release managers be listed in some form, but I think that can be considered separately from this. I like what Karen has proposed. |
- revert git contributor change from v0.069; opened (github) metacpan/metacpan-web#1270 instead. - order contributors by number of commits, descending - no longer adding an $AUTHORITY variable to modules, as nothing (save Class::MOP, Moose and Moo) has ever used it - this also avoids shifting our line numbers by 3
Background:
#authors
corresponds to the list found in the distribution metadata under thex_contributors
key.These two sets of names aren't the full list of people that should be credited with the distribution. For example, let's take a look at: https://metacpan.org/release/ETHER/Dist-Zilla-Plugin-MakeMaker-Awesome-0.22#authors
I (ether) did the last upload, but I'm not one of the distribution authors (that's AVAR, as seen at https://metacpan.org/source/ETHER/Dist-Zilla-Plugin-MakeMaker-Awesome-0.22/META.json#L3). Avar gets no credit in the right sidebar at all, and ether gets listed twice, as the releaser and one of the contributors!
This happens because the contributor list (which is added to metadata and pod) is being tailored for the pod: there is an authors section (which lists Avar) and then there is a Contributors section (which lists everyone else, including ether). When the list of contributor names are extracted from git history, the authors are removed, because they get their own pod section.
What I would propose is this change on metacpan, for deciding what contributors to list at
#authors
:x_contributors
metadataauthors
metadata field)This should come out looking a bit nicer.
The text was updated successfully, but these errors were encountered: