Skip to content

Contributors improvements #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2014
Merged

Conversation

haarg
Copy link
Member

@haarg haarg commented Aug 13, 2014

This improves the handling of contributors. It refactors the code some, allowing the contributor list to be shown on the module pages as well as the release page. It also includes authors listed in the metadata to the contributor list, and removes the releaser. This fixes #1270. Finally, it improves the formatting of the list so the 'and x contributors' label doesn't move when showing the list, and limits the width of the list so it lines up nicely with the rest of the sidebar.

@karenetheridge
Copy link
Contributor

+1

oalders added a commit that referenced this pull request Aug 15, 2014
@oalders oalders merged commit 82c88e1 into metacpan:master Aug 15, 2014
@oalders
Copy link
Member

oalders commented Aug 15, 2014

I wonder if we should use Unicode::Collate to sort the contributor names?

@karenetheridge
Copy link
Contributor

I wonder if we should use Unicode::Collate to sort the contributor names?

The list already comes sorted (it's an array, not a hashref of keys), so it's not unreasonable to respect the order that it comes in. (For some dists I'm sorting the names by number of contributions, descending.)

@haarg
Copy link
Member Author

haarg commented Aug 15, 2014

When writing this, I wanted author names to show up first. And collaborators have a defined order in the meta file already.

Looking at it now though, it looks a little sloppy. Presenting the authors first is probably good, but maybe marking them somehow to distinguish them from the rest of the list. Possibly using a small icon near them with a tooltip.

@haarg haarg deleted the contributors-improvements branch September 8, 2014 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Names and gravatars for authors and contributors can be improved
3 participants