Improve no result page #1210
Improve no result page #1210
Conversation
|
These screenshots look great! @oiami++ |
|
This looks really good. We could probably incorporate the "something missing? find out why" into the "No Result" box as well. Would be good to keep that all in one place. |
|
@oalders Do you like the ..."something missing?" part placed before or after the text ? how about before like .. |
|
@oiami I think that's good. We may want to refine it at some point, but let's see how people react to it first. |
|
@tsibley are you going to make the change on my messy regex ? I just pushed another commit (merge 'Something missing ..' into no result box) and seem to be last commit for this pull request if there's nothing else to fix. |
| ); | ||
|
|
||
| use Data::Dump qw/dump/; | ||
| warn dump( $res->content ); |
There was a problem hiding this comment.
Oops, these dump lines look like leftovers from debugging :-)
There was a problem hiding this comment.
ahh, this is always my annoying habit that I'm trying to improve. I always too hurry and forget to diff the code before I push :(. I'll fix that.
|
This is some great work. |
|
@oiami TIMTOWTDI, but I would personally change those regexp lines to something like: my $suggest = $query;
$suggest =~ s/:+/::/g;
if( $suggest ne $query ){That way the substitution is really simple and the code answers the question Would that accomplish what you intended? |
|
|
||
| if ( $results->{total} == 1 ) { | ||
| my $module_name | ||
| = $results->{results}->[0]->[0]->{module}->[0]->{names}; |
There was a problem hiding this comment.
The names key should just be name.
I know this functionality would be difficult to write a reliable test for (since we use live data)
but we might be able to do it by mocking a method in the tests.
I tried searching manually and had success searching for this word: "hashkeyorderbrokenagain".
There was a problem hiding this comment.
I'll add test check the response code should be 302 an get new location to the module ('/pod/module::name') is that ok?
…t Task::Kensho on no result
…ng missing ..' to no result box
|
New changes
|
|
Looks great! Lots of issues got addressed here. |
I've done mostly on No result and a little on result page. Changes are:
*Hopefully we can add more suggestion keywords using suggester from ES but this could happen after we upgrade ES to later version (0.90+)
First intention was trying to make font size larger on no result page but as a result of the changes I've made. I removed the text ( 0 results (0.xxx seconds) ) from no result page but this change still apply to result page. Which I think it nicer. (What do you think ? :D)
I made these changes based on my opinion, so you might not like it or have better idea. Any comments and suggestions are really welcome if you could give me to make MetaCPAN be brighter and better :)