Skip to content

add irc links if included in metadata #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2014
Merged

Conversation

haarg
Copy link
Member

@haarg haarg commented Aug 15, 2014

This implements #1235, adding an IRC link using metadata, mibbit, or freenode's web client.

I think a web client is much friendlier than an irc:// link for the type of users this is trying to reach, but it may be good to present the raw link as well.

I'd prefer to get comments from the people on the issue before merging this.

@oalders
Copy link
Member

oalders commented Aug 23, 2014

@haarg Should we ping the people you specifically wanted feedback from?

@oalders
Copy link
Member

oalders commented Aug 25, 2014

@ribasushi: care to comment on this?

@ribasushi
Copy link

The frenode webclient defaults are rather braindead - instead you want to use the link from #1235 (comment) https://webchat.freenode.net/?randomnick=1&prompt=1&channels=#$1

I am not entirely sure it is prudent to provide support for x_WebIRC. The only reason I did it this way in DBIC is because I am not capable of emitting version 2 meta without ditching MI, and this is another yak to shave I don't have the arms for at this moment, and most importantly - this isn't metacpan's problem.

Basically what I am trying to say is that supporting a shitton of different x_ things is counterproductive, especially when there is no prior art for this. I would be strongly in favor of only supporting the heuristics method and the spec as outlined in #1235 (comment)

Other than that - pretty please!

@haarg
Copy link
Member Author

haarg commented Aug 26, 2014

The various ways IRC data is listed in metadata is due to the different handling of custom keys in meta 1.4 vs 2.0. In meta 1.4 custom keys must start with a capital letter, vs 2.0 requiring x_. The odd variants all seem to be due to this and the various up/down converting of the metadata.

x_IRC (IRC in meta v1) seems the most commonly used variant, so I'm going to stick with just handling that.
I added x_WebIRC support specifically for things that were still using meta v1. It's not hard to leave out, and with the automatic web link generation it shouldn't be a big loss.

@haarg haarg changed the title add irc links if included in metadata - not ready for merge add irc links if included in metadata Aug 26, 2014
@haarg
Copy link
Member Author

haarg commented Aug 26, 2014

This should be good to go now.

oalders added a commit that referenced this pull request Aug 29, 2014
add irc links if included in metadata
@oalders oalders merged commit 8b60ab7 into metacpan:master Aug 29, 2014
@haarg haarg deleted the irc-display branch September 8, 2014 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants