Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add citation formatter #420

Open
wants to merge 1 commit into
base: 4.4.x
Choose a base branch
from
Open

Add citation formatter #420

wants to merge 1 commit into from

Conversation

josegar74
Copy link
Contributor

@josegar74 josegar74 commented Jan 30, 2025

This pull request adds the citation formatter to HNAP.

To test, create / load a HNAP metadata and check the formatter:

http://localhost:8080/geonetwork/srv/api/records/UUID/formatters/citation?format=ris


The pull request is targeted to branch 4.4.x with the label backport-4.2.x to test, when merged, the backport GitHub action to create the pull request for 4.2.x branch.

@josegar74 josegar74 added this to the 4.4.7 milestone Jan 30, 2025
@jodygarnett
Copy link
Member

Needed to make a small change (#421) to test this on a fresh build.

@jodygarnett
Copy link
Member

jodygarnett commented Feb 7, 2025

I am getting indexing errors trying to work off 4.4.x HNAP:

Error at xsl:variable on line 1079 column 89 of index.xsl:
  XPST0017: XPath syntax error at char 178 on line 1079 in {...tifier/*[text() != '']/text...}:
    Cannot find a matching 2-argument function named
  {java:org.fao.geonet.util.XslUtil}getTargetAssociatedResourcesAsNode()
2025-02-07T11:34:52,762 ERROR [geonetwork.index] - Indexing stylesheet contains errors: Failed to compile stylesheet. 1 error detected. 
  Marking the metadata as _indexingError=1 in index

See also #421 required to run 4.4.x.

Searching core-geonetwork:

  • XslUtil.getTargetAssociatedResourcesAsNode method is not defined on main or 4.2.x branches?

Copy link
Member

@jodygarnett jodygarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XslUtil.getTargetAssociatedResourcesAsNode() method is not found preventing HNAP records from being indexed.

Copy link
Member

@jodygarnett jodygarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejecting this PR to mark as blocked.
Due to #422 (unrelated issue to indexing records on 4.4.x.)

@josegar74
Copy link
Contributor Author

@jodygarnett please check #423 fixing the issue #422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants