Skip to content

Add info for local publishing with tag #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

TobiasNx
Copy link
Contributor

Like this?

Copy link
Member

@dr0i dr0i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to explain a bit more.

@dr0i dr0i assigned TobiasNx and unassigned dr0i Apr 10, 2025
@dr0i dr0i moved this to Review in Metafacture Apr 10, 2025
Co-authored-by: Pascal Christoph <[email protected]>
@TobiasNx TobiasNx requested a review from dr0i April 10, 2025 08:54
@dr0i
Copy link
Member

dr0i commented Apr 10, 2025

Please fix formatting to make build successful:

README.md:
94: Wrong amount of left-padding spaces(want multiple of 2)

@blackwinter
Copy link
Member

Can't we just get rid of this release detection logic? If you want to make a signed release, explicitly specify a parameter or execute a dedicated task.

@TobiasNx TobiasNx assigned dr0i and unassigned TobiasNx Apr 10, 2025
@dr0i
Copy link
Member

dr0i commented Apr 10, 2025

@blackwinter yes, you could do that. The release logic is overly complicated, so making this more simple would be nice.

@dr0i dr0i removed their assignment Apr 10, 2025
@blackwinter
Copy link
Member

See #684.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

3 participants