-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add draft for new find fix paths modul #347 #351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't commit the compiled class
. Always and only the source (*.java
)
Thanks @dr0i can you elaborate a little bit? For a noob like me? Where can I see if the class is compiled? And how can I keep the source? |
All java source files have the file suffix |
9cfe725
to
d5dba9f
Compare
Thanks did that. I compiled that and have run the following script with:
it returns empty, should return: |
d5dba9f
to
b8fc5c9
Compare
I assume that the string for |
b8fc5c9
to
a082cd5
Compare
@dr0i any idea why the string is not passed through? |
1236461
to
f925b09
Compare
f925b09
to
831a07b
Compare
831a07b
to
70a467f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
Just two inline suggestions (your name).
metafix/src/test/java/org/metafacture/metafix/FindFixPathsTest.java
Outdated
Show resolved
Hide resolved
metafix/src/test/java/org/metafacture/metafix/FindFixPathsTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Fabian Steeg <[email protected]>
See #347
@fsteeg as author of the
list-fix-paths
andlist-fix-value
wrappers could you review this new wrapper for finding the paths/keys to given value-patterns.