Merge pull request #612 from fenggw-fnst/fix-pipefail

🐛 Drop quiet option of grep to avoid race condition with pipefail
metal3-io · Jan 27, 2025 · a3c210b · a3c210b
2 parents 6ae9e16 + ba75723
commit a3c210b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/scripts/ironic-common.sh b/scripts/ironic-common.sh
@@ -19,13 +19,13 @@ get_provisioning_interface()
     local interface="provisioning"
 
     if [[ -n "${PROVISIONING_IP}" ]]; then
-        if ip -br addr show | grep -qi " ${PROVISIONING_IP}/"; then
+        if ip -br addr show | grep -i " ${PROVISIONING_IP}/" &>/dev/null; then
             interface="$(ip -br addr show | grep -i " ${PROVISIONING_IP}/" | cut -f 1 -d ' ' | cut -f 1 -d '@')"
         fi
     fi
 
     for mac in ${PROVISIONING_MACS//,/ }; do
-        if ip -br link show up | grep -qi "$mac"; then
+        if ip -br link show up | grep -i "$mac" &>/dev/null; then
             interface="$(ip -br link show up | grep -i "$mac" | cut -f 1 -d ' ' | cut -f 1 -d '@')"
             break
         fi