Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration for ironic-image release-28.0 #964

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Add configuration for ironic-image release-28.0 #964

merged 1 commit into from
Feb 25, 2025

Conversation

elfosardo
Copy link
Member

No description provided.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 20, 2025
@elfosardo elfosardo force-pushed the ironic-image-release-280 branch from 022e5f0 to 946da06 Compare February 20, 2025 14:47
@elfosardo
Copy link
Member Author

/cc @tuminoid @Sunnatillo

@elfosardo elfosardo mentioned this pull request Feb 20, 2025
Merged
Rozzii
Rozzii reviewed Feb 21, 2025
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2025
Rozzii
Rozzii reviewed Feb 21, 2025
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

dtantsur
dtantsur previously approved these changes Feb 23, 2025
View reviewed changes
tuminoid
tuminoid reviewed Feb 24, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Add the milestoneapplier config in plugins.yaml. I checked, we have appropriate milestones already configured.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2025
@elfosardo elfosardo force-pushed the ironic-image-release-280 branch from 946da06 to 574b2c8 Compare February 24, 2025 08:51
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
@elfosardo
Copy link
Member Author

@tuminoid done!

tuminoid
tuminoid reviewed Feb 24, 2025
View reviewed changes
@elfosardo elfosardo force-pushed the ironic-image-release-280 branch from 574b2c8 to f0f95a7 Compare February 24, 2025 14:22
@elfosardo
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2025
tuminoid
tuminoid reviewed Feb 25, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2025
@tuminoid
Copy link
Member

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Rozzii
Rozzii reviewed Feb 25, 2025
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@metal3-io-bot metal3-io-bot merged commit 804242f into metal3-io:main Feb 25, 2025
4 of 5 checks passed
@metal3-io-bot
Copy link
Collaborator

@elfosardo: Updated the following 2 configmaps:

  • job-config configmap in namespace prow at cluster default using the following files:
    • key ironic-image-release-28.0.yaml using file prow/config/jobs/metal3-io/ironic-image-release-28.0.yaml
  • plugins configmap in namespace prow at cluster default using the following files:
    • key plugins.yaml using file prow/config/plugins.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@Rozzii Rozzii Rozzii left review comments

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

@Sunnatillo Sunnatillo Awaiting requested review from Sunnatillo

@dtantsur dtantsur Awaiting requested review from dtantsur

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elfosardo @metal3-io-bot @tuminoid @dtantsur @Rozzii