Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add broken link check: general and pr #966

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

peppi-lotta
Copy link
Member

@peppi-lotta peppi-lotta commented Feb 26, 2025

These workflows can be called from the other Metal3 repos to test for broken links.
.github/workflows/broken-link-check.yml is for testing all md files in a repo
.github/workflows/pr-link-check.yml is for testing all .md files that have changed in a PR. This does not check all files but only the ones that have changed.

I've tested the pr workflow in situations listed below and it is giving the output I expect

  • .md file is edited and doesn't have any link (pass)
  • .md file is edited and has working links (pass)
  • .md file is edited and has broken link (fail)
  • pr does not have any edited .md files (pass)

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tuminoid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 26, 2025
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/add-link-check-work-flows branch from 89f2ba7 to a725c9c Compare February 26, 2025 11:08
@peppi-lotta peppi-lotta marked this pull request as draft February 26, 2025 11:24
@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2025
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just quick comment about the filenames at this point.

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/add-link-check-work-flows branch 2 times, most recently from ae6abc5 to fa0e146 Compare February 26, 2025 13:01
@peppi-lotta peppi-lotta marked this pull request as ready for review February 26, 2025 13:01
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2025
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/add-link-check-work-flows branch from fa0e146 to a6602f7 Compare February 26, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants