Add Tenable Nessus information model #7
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A weird modeling choice, but ok, that is how the XML model diverges in the upstream Tenable Nessus docs.
It turns out that PluginPreferences and ServerPreferences do not have the same structure internally with preferences, so we need to stop with the generalization.
Properly add the "preferences" assembly and embed it into the item assembly like the docs require for PluginPreferences.
You need to add the group-as to the definition of these fields because they can be zero to unbounded cardinality, which means in JSON we need to be explicit about serializing in the case of 1 .. N elements, even if not zero. If not, we rightfully get the following exception from the Metaschema module compiler when executing the command `metaschema-cli validate-content ...`: > Caused by: java.lang.IllegalStateException: Unable to derive the property name, due to missing group as name, for 'field-inline-definition:nessus:ReportItem/see_also@235154585'
The data as-is in real-world data doesn't use markup as guessed, so we
must consume the data as a long multiline string without markup and only
process it as a string to start.
Error messaging:
[ERROR] cvc-complex-type.2.4.b: The content of element 'plugin_output' is not complete. One of '{"http://www.nessus.org/cm":h1, "http://www.nessus.org/cm":h2, "http://www.nessus.org/cm":h3, "http://www.nessus.org/cm":h4, "http://www.nessus.org/cm":h5, "http://www.nessus.org/cm":h6, "http://www.nessus.org/cm":ul, "http://www.nessus.org/cm":ol, "http://www.nessus.org/cm":pre, "http://www.nessus.org/cm":hr, "http://www.nessus.org/cm":blockquote, "http://www.nessus.org/cm":p, "http://www.nessus.org/cm":table, "http://www.nessus.org/cm":img}' is expected. [file:/home/me/example.xml{2738,17}]
The data as-is in real-world data doesn't use date as guessed, so we
must consume the data as a long multiline string without markup and only
process it as a string to start.
Error messaging:
[ERROR] cvc-type.3.1.3: The value '2011/04/05' of element 'plugin_modification_date' is not valid. [file:/home/me/example.xml{2746,64}]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Closes #6 when reviewed and merged.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features: