Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also enable search in uri-fields #26

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

johtoblan
Copy link
Collaborator

Summary:

Related issue:

Suggested reviewer(s):

Reviewer checklist:

  • The headers of all files contain a reference to the repository license
  • 100% test coverage of new code - meaning:
    • The overall test coverage increased or remained the same as before
    • Every function is accompanied with a test suite
    • Tests are both positive (testing that the function work as intended with valid data) and negative (testing that the function behaves as expected with invalid data, e.g., that correct exceptions are thrown)
    • Functions with optional arguments have separate tests for all options
  • Examples are supported by doctests
  • All tests are passing
  • All names (e.g., files, classes, functions, variables) are explicit
  • Documentation (as docstrings) is complete and understandable

The checklist is based on the S-ENDA conventions and definition of done (see General Conventions). The above points are not necessarily relevant to all contributions. In that case, please add a short explanation to help the reviewer.

}

assert group.search("CC-BY-4.0") == license_dict
assert group.search("https://vocab.met.no/mmd/Use_Constraint") == license_dict
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be true.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

group is initialized on concept https://vocab.met.no/mmd/Use_Constraint, searching for the group name should not return CC-BY-4.0

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

searching for https://vocab.met.no/mmd/Use_Constraint/CC-BY-4.0 should be true though.

@mortenwh mortenwh linked an issue Oct 5, 2023 that may be closed by this pull request
@johtoblan
Copy link
Collaborator Author

The tests fail when checking the API (i.e. when not run with -m 'not live', which github does), so we need to write a test for the non-live version that catches the same error (As I noted in my comment on the code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to search for uri and exactly matching concepts
2 participants