implemented the get domain command #18
Conversation
| demisto.error('Job status URL not found in the response') | ||
| return response | ||
|
|
||
|
|
There was a problem hiding this comment.
@karand-metron Check what if job status is null/empty.
| Returns: | ||
| dict: A dictionary containing the search results | ||
| """ | ||
| demisto.debug(f'Searching domains with query: {query}') |
There was a problem hiding this comment.
@karand-metron Please remove the debug prints
| if len(domains) > 100: | ||
| raise DemistoException("Maximum of 100 domains can be submitted in a single request") | ||
|
|
||
| demisto.debug(f'Processing domains in bulk: {domains}') |
There was a problem hiding this comment.
| demisto.debug(f'Processing domains in bulk: {domains}') | |
| demisto.debug(f'Processing domains in bulk: {domains}') |
Please remove these prints
| """ | ||
| Command handler for fetching domain information. | ||
| domain = args.get('domain', 'silentpush.com') |
There was a problem hiding this comment.
| domain = args.get('domain', 'silentpush.com') | |
| domain = args.get('domain', 'silentpush.com') |
@karand-metron Please remove hard coded values
|
|
||
| domain = domain_list[0] | ||
| try: | ||
|
|
There was a problem hiding this comment.
We do not need separate API for getting single domain.
|
|
||
|
|
||
| job_complete = False | ||
| while not job_complete: |
There was a problem hiding this comment.
Seems like wrong logic for response receive for domain certificate.
| demisto.debug(f'Headers: {masked_headers}') | ||
| demisto.debug(f'Params: {params}') | ||
| demisto.debug(f'Data: {data}') | ||
|
|
There was a problem hiding this comment.
Let's not remove all the logs, can we have some logs, those are useful for debugging.
| domains = [domain.strip() for domain in domains_arg.split(',') if domain.strip()] | ||
| if len(domains) > 100: | ||
| raise DemistoException("A maximum of 100 domains can be submitted in a single request.") | ||
|
|
There was a problem hiding this comment.
Please remove so many empty lines in the code.
| fetch_whois_info = argToBoolean(args.get('fetch_whois_info', False)) | ||
|
|
||
|
|
||
| raw_response = client.list_domain_information(domains, fetch_risk_score, fetch_whois_info) | ||
|
|
There was a problem hiding this comment.
Remove empty lines from everywhere.
| if as_of: | ||
| params['as_of'] = as_of | ||
|
|
||
| try: |
There was a problem hiding this comment.
Explain why do we need an try except block here? are you handling any specific situation?
|
|
||
| url_suffix = "explore/bulk/ip2asn" | ||
|
|
||
| try: |
There was a problem hiding this comment.
Explain why do we need an try except block here?
|
|
||
|
|
||
|
|
||
| try: |
There was a problem hiding this comment.
Explain why do we need an try except block here?
There was a problem hiding this comment.
@karand-metron Let's try to add YMLMetadataCollector. This is the only way we can generate the .yml from .py file with all the validations. Here is the link for reference
|
|
||
|
|
||
|
|
||
| def test_module(client: Client) -> str: | ||
| try: | ||
| client.list_domain_information('silentpush.com') |
There was a problem hiding this comment.
Is there a specific reason you are using this function for the test command? In this command, we only need to verify that we can connect to the Client instance. If possible, try adding a simple method to test the connection.
| 'Common Name': cert.get('common_name', 'N/A'), | ||
| 'Subject Alternative Names': ', '.join(cert.get('subject_alt_names', [])), | ||
| } | ||
| markdown.append(tableToMarkdown('Certificate Information', [cert_info])) |
There was a problem hiding this comment.
Don't add tableToMarkdown() inside loop. Please update this in all the functions.
| limit = arg_to_number(args.get('limit')) | ||
|
|
||
| if not nameserver: | ||
| raise DemistoException("nameserver is a required parameter") |
There was a problem hiding this comment.
| raise DemistoException("nameserver is a required parameter") | |
| raise DemistoException("Nameserver is a required parameter.") |
implemented the get domain command