Adding 3 silent push commands. #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapil-metron
requested changes
Jan 31, 2025
| "support": "partner", | ||
| "currentVersion": "1.0.0", | ||
| "author": "Silent Push", | ||
| "author": "Yash", |
There was a problem hiding this comment.
Should you mention your name here?
There was a problem hiding this comment.
For DSPM also we added the client name only that's why I have added Silent Push here.
There was a problem hiding this comment.
but here, you have your name, can you please check:
"author": "Yash",
There was a problem hiding this comment.
oh sorry!! I will update it
| @metadata_collector.command( | ||
| command_name="silentpush-get-subnet-reputation", | ||
| inputs_list=SUBNET_REPUTATION_INPUTS, | ||
| outputs_prefix="SilentPush.NameserverReputation", |
There was a problem hiding this comment.
Suggested change
| outputs_prefix="SilentPush.NameserverReputation", | |
| outputs_prefix="SilentPush.SubnetReputation", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Must have