Keep-149-GCP-GO-SDK Develop #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devang-metron
requested changes
Feb 28, 2025
| @@ -0,0 +1,52 @@ | |||
| **GCP Cloud Key Management** | |||
There was a problem hiding this comment.
Should't this be inside GCP folder?
| // Creates a hash of the given configuration data. | ||
| func (g *GoogleCloudKeyVaultStorage) createHash(config []byte) string { | ||
| hash := md5.Sum(config) | ||
| return hex.EncodeToString(hash[:]) |
There was a problem hiding this comment.
Same comment as AWS PR.
Comment on lines
+123
to
+126
| g.config = config | ||
| if err := g.saveConfig(config); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
What is the point of saving, if it is loaded from file?
| return found | ||
| } | ||
|
|
||
| func (g *GoogleCloudKeyVaultStorage) ChangeKey(newKeyResourceName string) (bool, error) { |
There was a problem hiding this comment.
Is there any reason why changeKey is in storage file and for every other platform it was in the main file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.