Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript AWS key Vault #14

Open
wants to merge 4 commits into
base: metron-develop
Choose a base branch
from

Conversation

satish-metron
Copy link
Collaborator

This PR adds AWS Key Management Service support to Keeper JavaScript SDK to encrypt and decrypt configuration credentials.

@satish-metron satish-metron requested review from sajida-metron and a team February 20, 2025 11:21
@maksimu
Copy link

maksimu commented Feb 25, 2025

I see in the example code you have:

    import {AWSKeyValueStorage,AWSSessionConfig} from "@keeper-security/secrets-manager-aws";

Are we going to plan to publish it to NPM?

If yes, then can you add to this PR a new Github Action to publish the repo to NPM? Don't create that repository, I'll do it form our account. Just want to make sure we have a publishing pipeline for it.

@satish-metron
Copy link
Collaborator Author

I see in the example code you have:

    import {AWSKeyValueStorage,AWSSessionConfig} from "@keeper-security/secrets-manager-aws";

Are we going to plan to publish it to NPM?

If yes, then can you add to this PR a new Github Action to publish the repo to NPM? Don't create that repository, I'll do it form our account. Just want to make sure we have a publishing pipeline for it.

Ideally its better to publish to NPM because we can keep each integration separate and whoever uses it will just have pull specific integration from NPM.

Sure thing max, I will add a Github action for the process.

* KEEP-137 added job for publish

* KEEP-137 added decrypt config documentation
@satish-metron satish-metron added the typeScript SDK tag for typescript label Feb 28, 2025
@satish-metron satish-metron self-assigned this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typeScript SDK tag for typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants