Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove static UB #287

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Remove static UB #287

wants to merge 4 commits into from

Conversation

berkus
Copy link
Member

@berkus berkus commented Jan 30, 2025

Closes #286

@berkus berkus requested a review from Copilot January 30, 2025 22:36
@berkus berkus self-assigned this Jan 30, 2025
Copilot
Copilot AI reviewed Jan 30, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • machine/src/arch/aarch64/cpu/boot.s: Language not supported
  • machine/src/platform/raspberrypi/linker/kernel.ld: Language not supported
@berkus berkus force-pushed the fix/remove-static-ub branch from a21eda6 to 82c98b9 Compare January 30, 2025 22:41
@cocogitto-bot Cocogitto-bot
Copy link

cocogitto-bot bot commented Jan 31, 2025

❌ Found 3 compliant commit and 1 non-compliant commits in 88c088b...92a5cf9.

Commit 92a5cf9 by @berkus is not conform to the conventional commit specification :

  • message: wip: 🚧 Boot in chainboot
  • cause: 
    Errored commit: not committed <berkus>
	Commit message:'wip: 🚧 Boot in chainboot'
	Error:Commit type `wip` not allowed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@berkus berkus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean UB in BSS static initalization
1 participant
@berkus