This repository was archived by the owner on Jan 2, 2025. It is now read-only.
Improvements to collection keyboard navigation #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, keyboard modifiers (Ctrl/Alt/Meta) were ignored when looking up keyboard shortcuts. This made it impossible to use the browser's native ArrowLeftAlt/ArrowRightAlt shortcuts for history navigation, since the plugin would also perform navigation of its own on the same shortcuts. This commit fixes that problem by suffixing the `key` string with all possible modifiers, so it won't match shortcuts with extra modifiers.
* Navigation starts slightly sooner, for improved perceived performance. * When typing rapidly, users may roll over and release the modifier before releasing the modified key (but will never press the modified key before its modifier, since that doesn't work). Using keyup means that we may see the event after the user has already released the modifier; with keydown this is not the case. * The browser also performs actions during the keydown event, so if we use the same event they can be intercepted to prevent the browser from taking actions of its own (this will be done in the next commit).
We fixed the problem for the default browser keybindings by checking for all modifiers, but there's still the possibility that the user's browser has some custom keybindings that conflict with ours. In this situation it would probably be undesirable for the browser to also take its action, so tell it that we've already handled the situation.
|
@mgsisk bump - LMK if there's anything you need from me on this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Fix collisions between browser shortcuts and comic next/previous navigation. See commit messages for full details.
Bug Fix – Fixes an issue with existing functionality
Context
Previously, keyboard modifiers (Ctrl/Alt/Meta) were ignored when looking up keyboard shortcuts. This made it impossible to use the browser's native ArrowLeftAlt/ArrowRightAlt shortcuts for history navigation, since the plugin would also perform navigation of its own on the same shortcuts.
Verification
I have added tests to cover all changesI have verified that all new and existing tests pass(N/A, there don't seem to be tests for JS)
(as Vagrant provisioning seems to be broken, tested by replacing
wp-content/plugins/webcomic/srv/collection/common.jswith an unminified, modified version)