-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2151 skip to content component #3101
base: v3.0.0/develop
Are you sure you want to change the base?
Conversation
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/2151-skip-to-content-component/web-components |
c9d0690
to
39cd82d
Compare
39cd82d
to
efe3184
Compare
packages/web-components/src/components/ic-skip-link/ic-skip-link.css
Outdated
Show resolved
Hide resolved
ffd4cbe
to
e7c07d4
Compare
0dd754d
to
a794d67
Compare
a794d67
to
d67a949
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks so good, noticed a few things but they are quite small :)
packages/web-components/src/components/ic-skip-link/ic-skip-link.stories.mdx
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/ic-skip-link/ic-skip-link.tsx
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/ic-skip-link/ic-skip-link.tsx
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/ic-skip-link/ic-skip-link.tsx
Outdated
Show resolved
Hide resolved
fa8f16c
to
8f687d3
Compare
fbef52f
to
0486758
Compare
Cypress visual tests failed. |
713b877
to
f71be7a
Compare
I'm still getting an issue with the full-width variant. It appears correctly if you keep the window at the same size, but once you make it bigger or smaller, the skip link no longer matches the window width i.e. it either gets cut off or is not wide enough Everything else looks good to me now though :) |
8f3440b
to
8a04dce
Compare
c49d01f
to
57bb3a7
Compare
8d14ba9
to
566d663
Compare
The merge-base changed after approval.
46015cc
to
7cab72a
Compare
57bb3a7
to
f98a7dc
Compare
added an ic-skip-link component, including relevant props, styling and stories. Included spec tests, and added some new color tokens to global css files
added new component definition to react package for ic-skip-link. Also added stories and cypress tests
added ic-skip-link to docs package
f98a7dc
to
49d5781
Compare
NOTE: Do not merge until guidance is ready.
Summary of the changes
ic-skip-link
component to the web-components package (final confirmation from design still needed).Related issue
#2151
Checklist
General
Testing
Accessibility
Resize/zoom behaviour
System modes
Testing content extremes