-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge v3 develop into v3 main #3230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCHQ-Developer-299
previously approved these changes
Feb 20, 2025
GCHQ-Developer-847
previously approved these changes
Feb 20, 2025
8d14ba9
to
566d663
Compare
a1d1f9a
MI6-255
previously approved these changes
Feb 21, 2025
MI6-255
previously approved these changes
Feb 21, 2025
GCHQ-Developer-299
previously approved these changes
Feb 21, 2025
1c8bdd9
to
566d663
Compare
46015cc
Update audit dates for March
Update docs.json with empty state theme prop
Update empty state to have theme prop to make use of light/dark theme
Update data table empty state cypress image
Update empty state to have theme prop to make use of light/dark theme
Update tree view to prevent FOUC - set tree items visibility to hidden until loaded when inherited props from tree view used. Removed timeouts on truncation - tree view now truncates when ready rather than waiting 0.1 seconds to help reduce flashing.
…d items Update tree view truncation story to have expanded items - to show truncation working on nesting items.
deployments to npm now run from a dedicated release branch, once complete, are then merged into develop, then main. This prevents any conflicts or needing to merge main back into develop. 2765
…ide nav item when dark Fix double focus indicator on side nav item (light theme colour / dark foreground) when it is selected and a slotted link is used.
…ix storybook example Update visual regression images in IcAlert and IcTheme, fix storybook example after height change fix in ic-alert
…themes variables added to variables.css, container min-height now changes on theme change to compensate for border in dark mode
changed auto-dismiss toasts from role=status to alert, so they read to screenreaders Made the auto-dismiss toasts polite so they don't interrupt navigation 2710
update the message of the Auto-dismiss toast react story to be more clear about functionality 2710
…able Implement disableAutoSort prop on data table so that the sort button appears and emits a sort event but doesn't actually sort the data . #2415
Update docs.json with disableAutoSort prop on data table
Implement disableAutoSort prop on data table so that the sort button appears and emits a sort event but doesn't actually sort the data . #2415
description change to say defult button will not be shown however, slotted controls will
adds workflow to trigger v3 guidance site update
Update to Storybook v8 - .stories.mdx replaced with new format of .stories.js and .mdx
Update to storybook v8 - with new format for stories
replace references to regular develop with v3 develop
replace references to release with v3.0.0/release in the v3 release check script
fixes build by committing files which have changed
delete development release check file to unblock release
- @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected]
…first load Add Cypress test to check that interactive elements are focussable when they are slotted in after first load (also includes updates to children of slotted elements). Update React storybook - move slotted interactive content behaviour to separate story (matching web components storybook) and add child slotted element for checking new fix. .#2773
…en content focussable Update ic-dialog to make interactive children of slotted elements focussable when added after first page load. Update web components storybook to help test that the fix works. .#2773
improve the layout of the release check file, so it is easily readable on new lines. Additionally, the versions for react and web-components will be checked in canary/stable, including the v3 branches 2765
46015cc
to
7cab72a
Compare
GCHQ-Developer-299
approved these changes
Feb 24, 2025
MI6-255
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure all changes are in main