Fix/2773 dialog v3 cherry pick #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…first load Add Cypress test to check that interactive elements are focussable when they are slotted in after first load (also includes updates to children of slotted elements). Update React storybook - move slotted interactive content behaviour to separate story (matching web components storybook) and add child slotted element for checking new fix. .#2773
…en content focussable Update ic-dialog to make interactive children of slotted elements focussable when added after first page load. Update web components storybook to help test that the fix works. .#2773
|
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/fix/2773-dialog-v3-cherry-pick/web-components |
GCHQ-Developer-299
approved these changes
Feb 21, 2025
GCHQ-Developer-530
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
V3 cherry pick for PR #3218.
Related issue
#2773