Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(canary-web-components): truncation on first render #3238

Merged

Conversation

cd3859
Copy link
Contributor

@cd3859 cd3859 commented Feb 21, 2025

Summary of the changes

modified tree view to allow tree items to truncate on first render

to test:

  • open storybook and go to truncated behavior, should emulate correct behavior without loading state

Related issue

#3171

Checklist

General

  • Changes to docs package checked and committed.
  • All acceptance criteria reviewed and met.

Testing

  • Relevant unit tests and visual regression tests added.
  • Visual testing against Figma component specification completed.
  • Playground stories in React Storybook up to date, with any prop changes and additions addressed.
  • Compare performance of modified components against develop using Performance addon in React Storybook.

Accessibility

  • Accessibility Insights FastPass performed.
  • A11y unit test added and yields no issues.
  • A11y plug-in on Storybook yields no issues.
  • Manual screen reader testing performed using NVDA and VoiceOver.
  • Manual keyboard testing for keyboard controls and logical focus order.
  • Correct roles used and ARIA attributes used correctly where required.
  • Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

  • Page can be zoomed to 400% with no loss of content.
  • Screen magnifier used with no issues.
  • Text resized to 200% with no loss of content.
  • Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

  • Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
  • Windows High Contrast mode tested with no loss of content.
  • System light and dark mode tested with no loss of content.
  • Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

  • Min/max content examples tested with no loss of content or overflow.
  • All prop combinations work without issue.
  • Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
  • Controlled and uncontrolled input components tested.
  • Props/slots can be updated after initial render.

Copy link
Contributor

@MI6-255 MI6-255 force-pushed the v3.0.0/develop branch 2 times, most recently from 46015cc to 7cab72a Compare February 24, 2025 11:34
@cd3859 cd3859 force-pushed the 3171-inconsistencies-with-ictreeview-truncation branch from 487a9a4 to 6ecaafe Compare February 24, 2025 12:38
@cd3859 cd3859 changed the title fix(tree-view): truncation on first render fix(canary-web-components): truncation on first render Feb 24, 2025
@GCHQ-Developer-530
Copy link
Contributor

Please could you update the commit to match the PR title e.g. fix(canary-web-components)

@cd3859 cd3859 force-pushed the 3171-inconsistencies-with-ictreeview-truncation branch from 6ecaafe to 9365b0d Compare February 25, 2025 09:30
@ad9242 ad9242 merged commit 10ca79c into v3.0.0/develop Feb 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants