2913 fix toggle button focus border #3250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating inner border of focused toggle button
…e button adding visual regression test for focused, checked toggle button with dark theme
|
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/2913-fix-toggle-button-focus-border/web-components |
gd2910
approved these changes
Feb 24, 2025
GCHQ-Developer-530
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Updated the inner border of focused, checked toggle button so that it is black in dark mode, and added a visual regression test for this scenario.
Related issue
#2913
Checklist
General
Testing
Accessibility