chore: add consolidated SBOM generation workflow - #765
Merged
Conversation
- Single sbom.yml workflow replaces duplicate sbom-release.yml - Pinned syft version (v1.41.0) for supply-chain integrity - Uses gh-token GITHUB_TOKEN for release asset management - Idempotent: deletes existing SBOM asset before re-upload - Fixed shell syntax (no stray quoted string) - Runs on v* tag pushes only
michaeldcanady
added
the
no-issue-required
github-actions
Bot
added
the
type: devops
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Requesting changes — the workflow as written will fail on first run and will also trip the repo's blocking zizmor gate.
- Critical:
$SYFT_VERSIONis referenced in the "Install Syft" step but only defined in the next step'senv:block — it expands empty, making the install URL/v/install.sha 404. Move the env var up (job- or step-level) so both steps see it. - CI-gating:
actions/checkout@v4/actions/setup-go@v5are mutable-tag refs, unlike the SHA-pinnedactions/*used everywhere else in this repo.zizmor.ymlruns blocking at informational severity on PRs and will flagunaudited, failing the merge. Pin to the same SHAs used inci.yml. - Nit: the stray quoted string on the last line is still present (PR description claims it was removed); collapse that multi-line notice into one
echo.
All three have inline comments with concrete fixes.
Contributor
|
Review posted. Summary of the review: Requesting changes — posted 3 inline comments + a top-level review on PR #765.
Also noted (not commented): the PR description says it "replaces duplicate sbom-release.yml," but that file doesn't exist on |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Resolve the issues that blocked PR #764: fix the stray quoted string in the final run block, move the syft SYFT_VERSION env onto the install step and drop its double-v, SHA-pin checkout and drop the unused setup-go step, and replace the moving curl|sh syft install with a pinned release download verified against its published checksum. Scope release-upload permissions to the job and move RELEASE_ID into env to silence zizmor. The workflow now passes zizmor with no findings. Co-authored-by: opencode <opencode@local>
michaeldcanady
force-pushed
the
chore/sbom-release-workflow
branch
from
September 1, 2026 00:40
a9885c9 to
ed21ea6
Compare
michaeldcanady
dismissed
github-actions[bot]’s stale review
September 1, 2026 00:47
All issues raised in this stale review (SYFT_VERSION install-step scoping + double-v, unpinned actions/checkout, unused setup-go step, and the stray trailing quoted-string line) have been fixed and verified in commit ed21ea6. CI (zizmor, branch-policy, etc.) is green on the current head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: add consolidated SBOM generation workflow