Conversation
micke
approved these changes
Feb 12, 2025
Owner
micke
left a comment
micke
left a comment
There was a problem hiding this comment.
Haha, caching sure is hard when you don't persist the cache! 😂
You've got some failing specs but once those are fixed this looks good to go!
phoet
force-pushed
the
class_level_cache
branch
10 times, most recently
from
243e32f to
bf40e93
Compare
phoet
force-pushed
the
class_level_cache
branch
from
bf40e93 to
9347e3e
Compare
Collaborator
Author
|
@micke yeah well that took some back and forth to get it fixed in the matrix tests. good that it's already lined up, it would have blown up in older ruby versions. |
phoet
added a commit
that referenced
this pull request
Feb 13, 2025
* use debug gem for proper stepping and such * pull out dns and use a class level cache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as mentioned here #256 (comment) by @natematykiewicz it seems like the cache not actually doing anything right now.
i've pulled out the DNS handling and moved caching to a class-level, so this should be fixed.
i have kept most of the caching specs in place so it's easy to follow the changes. they are quite verbose and repetitive. i think they should be refactored in another step.