updates project to work with zephyr v4.0.x #146
Conversation
|
Hello would you mind updating both workflows to make this compatible with your PR? |
|
Absolutely- I'll try to have these changes done in the next 24 hours. |
|
I have added an attempt to update the workflows. I was testing locally using 'act', but I was having some difficulty getting the checkout to match the 'ref'. Instead, it appeared that the microROS-zephyr-module repo in the 'act' execution environment always matched whatever was currently checked out locally. I'll have to examine the docs a bit more. Additionally, I also could not get any workflows to automatically appear in the 'Actions' pane on the Github page of my fork of the project. Are the workflows auto-populated somehow or do I need to perform some manual setup? Thanks! |
|
CI running, it seems that I need to approve the execution |
|
Next attempt to fix the workflows. As for the issues I previously ran into: I was surprised the previous ci.yml change didn't build correctly. My local execution runs were successful. Nevertheless, I have made some adjustments to hopefully get the SDK detected correctly. |
| pull_request: | ||
| branches: | ||
| - '**' | ||
| branches-ignore: ["iron", "rolling", "humble"] |
There was a problem hiding this comment.
Please do not ignore PR to active branches
| - uses: actions/checkout@v4 | ||
| with: | ||
| path: micro_ros_zephyr_module | ||
| branch: ${{ matrix.branch }} | ||
| ref: jazzy |
There was a problem hiding this comment.
Nightly is not running all ROS 2 distros as in previous approach
There was a problem hiding this comment.
Hello @pablogs9. Thanks for the feedback.
Currently, I have split the GitHub actions into the following configurations:
-
The iron/rolling/humble coverage was moved into GitHub actions called "legacy_ci.yml" and "legacy_nightly.yml". These "legacy" actions test the iron/rolling/humble branches against Zephyr versions v3.1.0 and v2.7.2, using the Zephyr docker image based on SDK 0.14.2. [This matches the configuration currently in use by this microROS Zephyr project.]
-
The jazzy coverage is in "ci.yml" and "nightly.yml". These actions are running with Zephyr version v4.0.99, using the Zephyr docker image based on SDK 0.16.9-rc3.
Is it imperative that the older ROS 2 distros run on the newer Zephyr setup?
There was a problem hiding this comment.
Hello @Z0rdon,
Humble is an active distro until May 2027 and Rolling is "newer" than Jazzy.
I'm okay with getting rid of Iron since it is EOL.
Concerning the CI, ideally, we need to have a single workflow that tests the module for all active distros.
Upticks the compatible zephyr version.
The 'zephyr_library_import' needed to be replaced with 'zephyr_link_libraries' to avoid the 'whole-archive' linking behavior (which would consume massive amounts of RAM).
Other miscellaneous fixes were made in order to build.