Seperate CI for focal and jammy. Added humble distro to workflow #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arne Nordmann <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 32.72% 35.39% +2.67%
==========================================
Files 14 14
Lines 1048 1226 +178
Branches 754 807 +53
==========================================
+ Hits 343 434 +91
- Misses 114 210 +96
+ Partials 591 582 -9
Continue to review full report at Codecov.
|
added 2 commits
June 5, 2022 11:34
Signed-off-by: Arne Nordmann <[email protected]>
Let cpplint ignore include-order, as the desired order was now updated and would need separate branches for foxy+galactic and humble+rolling. Signed-off-by: Arne Nordmann <[email protected]>
|
If I see it correctly, the only difference between the two Action workflow files is the Linux distribution. Two files are not necessary. The ROS distributions and the corresponding Linux distributions can be also specified as a list of pairs, cf. https://github.com/boschresearch/fmi_adapter/blob/master/.github/workflows/build_and_test.yml#L16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configures two (almost identical) workflows
Had to exclude include-order from cpplint, as it is expecting different orders on foxy+galactic resp. humble+rolling and I don't want to branch just for this.
Signed-off-by: Arne Nordmann [email protected]