Introduce per-convention MeterConvention types and builder pattern#7369
Draft
shakuzen wants to merge 1 commit into
Draft
Introduce per-convention MeterConvention types and builder pattern#7369shakuzen wants to merge 1 commit into
shakuzen wants to merge 1 commit into
Conversation
Replace group interfaces (e.g., JvmMemoryMeterConventions) with specific per-convention interfaces (e.g., JvmMemoryUsedMeterConvention) following the proven ObservationConvention pattern. This resolves issues where the OTel variant extending the Micrometer variant made Spring Boot auto-configuration awkward, and where customizing a single meter required implementing the entire group interface. Each binder now has a builder with per-convention setters and an openTelemetryConventions() convenience method. The binder merges extra tags itself so conventions stay purely semantic. Each specific interface provides a static of() factory for inline custom implementations. Group interfaces and their implementations are deprecated in favor of the new per-convention types and builders. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace group interfaces (e.g., JvmMemoryMeterConventions) with specific per-convention interfaces (e.g., JvmMemoryUsedMeterConvention) following the proven ObservationConvention pattern. This resolves issues where the OTel variant extending the Micrometer variant made Spring Boot auto-configuration awkward, and where customizing a single meter required implementing the entire group interface.
Each binder now has a builder with per-convention setters and an openTelemetryConventions() convenience method. The binder merges extra tags itself so conventions stay purely semantic. Each specific interface provides a static of() factory for inline custom implementations.
Group interfaces and their implementations are deprecated in favor of the new per-convention types and builders.