feat: use typed Prometheus family descriptors#7487
Draft
zeitlinger wants to merge 9 commits into
Draft
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a cleaner follow-up to the Prometheus metadata compatibility work for Micrometer.
Instead of reconstructing
MetricMetadatafrom Micrometer-side suffix logic, this change switches the Prometheus registry integration to use the new typed registration descriptor API fromclient_java.Depends on:
Related context:
What changed
MetricFamilyDescriptorMetricMetadatareconstruction for registration metadataWhy
Micrometer needs registration-time family metadata for collision validation, but the old shape forced Micrometer to duplicate Prometheus naming derivation details.
With
client_javaexposing typed family descriptors, Micrometer can now treat Prometheus metadata as an upstream concern instead of rebuilding it locally.Validation
Tested locally against a locally installed
prometheus/client_java1.6.2-SNAPSHOTcontaining the descriptor API from prometheus/client_java#2114:Notes
prometheus/client_java#2114first.