Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

content negotiation guide #1392

Merged
merged 3 commits into from
Dec 12, 2023
Merged

content negotiation guide #1392

merged 3 commits into from
Dec 12, 2023

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Dec 11, 2023 

./gradlew clean micronautContentNegotiationBuild

@sdelamo sdelamo requested a review from timyates December 11, 2023 17:02
timyates
timyates approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My usual whitespace commit (I prefer ternary's with ? and : at the start of the line when they are multiline?)

I also changed the test to compare the full html response... Not sure if this is ok? Using String.contains makes me uneasy in tests

@sdelamo sdelamo merged commit 8ff1762 into master Dec 12, 2023
2 checks passed
@sdelamo sdelamo deleted the content-negotiation branch December 12, 2023 10:47
AndreaLaGrotteria pushed a commit to AndreaLaGrotteria/micronaut-guides that referenced this pull request Oct 3, 2024
@sdelamo @timyates
content negotiation guide (micronaut-projects#1392)
6f071aa 
* content negotiation guide

* Whitespace, ternary format and imports

* Compare full html document

---------

Co-authored-by: Tim Yates <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timyates timyates timyates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
4.2.2 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdelamo @timyates