Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert breaking change #1563

Merged
merged 4 commits into from
Jan 25, 2024
Merged

revert breaking change #1563

merged 4 commits into from
Jan 25, 2024

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Jan 25, 2024

Several breaking changes were introduced accidentally in #1526

if a user had a bean extending AuthenticationProvider they will get:

java/example/micronaut/AuthenticationProviderUserPassword.java:29: error: wrong number of type arguments; required 3
public class AuthenticationProviderUserPassword implements AuthenticationProvider<HttpRequest<?>>  { // <2>
                                                                                 ^

This PR reverts the changes to Authenticator and AuthenticationProvider so that users are able to upgrade their applications and see only a deprecation notice.

@sdelamo sdelamo added the type: bug Something isn't working label Jan 25, 2024
@sdelamo sdelamo requested a review from timyates January 25, 2024 09:35
Copy link

sonarqubecloud bot commented Jan 25, 2024

@sdelamo sdelamo merged commit 2988abc into master Jan 25, 2024
17 checks passed
@sdelamo sdelamo deleted the breaking-change branch January 25, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants