-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports continuous speech recognition and barge-in #5426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
OEvgeny
reviewed
Feb 13, 2025
OEvgeny
reviewed
Feb 13, 2025
OEvgeny
reviewed
Feb 13, 2025
OEvgeny
previously approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid, couple of nits and questions
OEvgeny
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
styleOptions.speechRecognitionContinuous
totrue
with a Web Speech API provider with continuous mode supportChanged
[email protected]
Description
Continuous mode is designed for hands-off/kiosk scenario. End-users can hold a speech-primary conversation with the bot, and occasionally, interact with gestures (e.g. tapping on a card). Speech recognition will be kept active as long as possible, until end-user turn off speech recognition.
Added new
styleOptions.speechRecognitionContinuous
to enable continuous mode for speech recognition.Design
Behavioral differences
end
event is received, and not becauseresult
event is receivedend
event after speech is recognizedTechnical details
start
event is receivedend
event is receivedSpeechRecognition.continuous
property, but depends on the event dispatched by the Web Speech API providerend
eventresult
event withresultIndex
pointing to a result which itsisFinal
property is trueevent.results[event.resultIndex].isFinal === true
Specific Changes
styleOptions.speechRecognitionContinuous
CHANGELOG.md
I have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)