Skip to content

[SER] HitObject accessors HLSL -> DXIL lowering #7360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Apr 23, 2025
Merged

[SER] HitObject accessors HLSL -> DXIL lowering #7360

merged 27 commits into from
Apr 23, 2025

Conversation

simoll
Copy link
Contributor

@simoll simoll commented Apr 17, 2025

Lowering for all HitObject accessors (ex GetAttributes)

Specification: https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md
DXC SER implementation tracker:: #7214

simoll and others added 24 commits March 26, 2025 13:28
@simoll
[SER] DxHitObject::MakeNop|Miss lowering and tests
f79d0ca 
- HLSL -> DXIL lowering
- ast, hlsl->dxil, dxilgen, and ScalarReplAggregatesHLSL tests

SER implementation tracker (microsoft#7214)
@simoll
[ser][nfc] Use 'unsigned' for argument idx to resolve compile warnings
e7e8781
@simoll
[ser][nfc] Upper-case variable names in TranslateHitObjectMake
46e3623
@simoll
Merge remote-tracking branch 'msft/main' into ser_hlslmake_patch
afebf8d
@simoll @llvm-beanz
Update tools/clang/test/DXC/Passes/DxilGen/maybereorder_dxilgen.ll
834f9d6 
Co-authored-by: Chris B <[email protected]>
@simoll
nfc. Remove REQUIRES lines from test that doesn't need it
920745c
@simoll
Fuse fcgl and ast tests into one CodeGenDXIL test
a79d324
@simoll
Merge remote-tracking branch 'msft/main' into staging/ser_hlslmake_patch
1acd442
@simoll
nfc: removed unneede REQUIRES line
e879edb
@simoll
nfc: dont match specific outvarname
0cea5c8
@simoll
Merge remote-tracking branch 'msft/main' into ser_hlslmake_patch
6834013
@simoll
Add MaybeReorderThread HLSL -> DXIL lowering and add tests
9be6abf
@simoll
nfc: match var
47056ff
@tex3d
Merge remote-tracking branch 'ms/main' into ser_hlslmake_patch
350735b
@tex3d
Fix tests with updated hl opcodes
c541236
@simoll
Check value flow in scalarrepl test
1087cd2
@simoll
explicitly check for scalarization of RayDesc
9a977c3
@simoll
Add back REQUIRES: dxil-1-9 now that we are testing the dxil
57b5fdd
@simoll
Revert "Add back REQUIRES: dxil-1-9 now that we are testing the dxil"
601a8af 
This reverts commit 57b5fdd.
@simoll
Assert that return value of HitObject default ctor is unused ('this' …
93f9f2a 
…return is a Clang codegen artifact)
@simoll
Add lit.local.cfg to CodeGenDXIL HitObject/ dir
c32d06f
@simoll
nfc: assert RayDescOpIdx == SrcIdx
afb6794
@simoll
Merge remote-tracking branch 'msft/main' into ser_hlslmake_patch
c5e0ec0
@simoll
[SER] HitObject accessors HLSL -> DXIL lowering
5086a92
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 17, 2025 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@simoll simoll mentioned this pull request Apr 17, 2025
Open
41 tasks
@simoll
Copy link
Contributor Author

simoll commented Apr 17, 2025

This PR is based on #7262 diff and will be updated once #7262 has been merged

tex3d
tex3d reviewed Apr 21, 2025
View reviewed changes
Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a pass test for dxilgen to test lowering in isolation, don't we?
Otherwise, looks good so far.

@simoll
Copy link
Contributor Author

simoll commented Apr 22, 2025

I think we need a pass test for dxilgen to test lowering in isolation, don't we? Otherwise, looks good so far.

Added the dxilgen test

@simoll simoll requested a review from tex3d April 22, 2025 20:57
@tex3d tex3d merged commit bddee27 into microsoft:main Apr 23, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Apr 23, 2025
@simoll simoll deleted the ser_hlslaccessors_patch branch April 23, 2025 16:54
@damyanp damyanp moved this to Closed in HLSL Support Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tex3d tex3d tex3d approved these changes

@llvm-beanz llvm-beanz llvm-beanz approved these changes

Assignees

@tex3d tex3d

@llvm-beanz llvm-beanz

Labels
None yet
Projects
HLSL Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simoll @tex3d @llvm-beanz