Gangams/windows telegraf update #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
build/common/installer/scripts/tomlparser-prom-customconfig.rb:116
- Removing the Windows-specific timeout configuration assumes that all environments will be running an updated version of Telegraf. Please confirm that this change does not break functionality in any Windows setups that may require the legacy 'response_timeout' behavior.
if is_windows?
wanlonghenry
approved these changes
Feb 21, 2025
ganga1980
added a commit
that referenced
this pull request
Feb 27, 2025
This reverts commit 9a8808d.
ganga1980
added a commit
that referenced
this pull request
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrade to latest available telegraf version for windows and update the telegraf configuration file to support the latest version.
Telegraf started with --service-auto-restart instead of start since start doesnt work after telegraf version 1.25.1.
This should also eliminate need of enabling the liveness probe on telegraf since telegraf will be restarted on failures.
Following scenarios verified ..