Classify more long response to timeout instead of 499 #23700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
server/routerlicious/packages/services-utils/src/morganLoggerMiddleware.ts:136
- Ensure that the new behavior for classifying server timeouts based on durationInMs > 20000 is covered by tests.
if (res.locals.serverTimeout || durationInMs > 20000) {
github-actions
bot
added
area: server
server/routerlicious/packages/services-utils/src/morganLoggerMiddleware.ts
Outdated
Show resolved
Hide resolved
added 2 commits
February 3, 2025 13:02
znewton
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some disconnection was triggered by proxy that is close to 30seconds before the server timeout, these misclassifed server timeout to 499, especially for EC
Breaking Changes
N/A