Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export SharedTreeFactory from @fluidframework/tree #23744

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

export SharedTreeFactory from @fluidframework/tree #23744

wants to merge 1 commit into from

Conversation

pragya91
Copy link
Contributor

@pragya91 pragya91 commented Feb 2, 2025

This PR exports SharedTreeFactory from @fluidframework/tree package.

@Copilot Copilot bot review requested due to automatic review settings February 2, 2025 05:44
@pragya91 pragya91 requested a review from a team as a code owner February 2, 2025 05:44
Copilot
Copilot AI reviewed Feb 2, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
@github-actions github-actions bot added base: main PRs targeted against main branch area: dds Issues related to distributed data structures area: dds: tree labels Feb 2, 2025
@pragya91
Copy link
Contributor Author

pragya91 commented Feb 2, 2025

Note for reviewers:
I am raising this PR based on the understanding that every DDS needs to have a factory exposed which can be used to create the corresponding DDS. This helps apps to just import the factory class, instead of importing SharedTree to get it's factory, hence helping in tree-shaking and reduce bundle impact on the client app.
This is also based on the pattern I noticed in other DDS in the repository.

I did not see any of the alpha, legacy, public etc. tags on this class, so I wasn't sure if not exporting the factory was intentional. Please review and guide : @taylorsw04 @CraigMacomber @yann-achard-MS @Abe27342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pragya91