Export Map and Directory Fuzz Models #23754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
base: main
There was a problem hiding this comment.
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (2)
- packages/dds/map/package.json: Language not supported
- packages/dds/map/src/test/tsconfig.json: Language not supported
Abe27342
reviewed
Feb 3, 2025
Abe27342
reviewed
Feb 3, 2025
Abe27342
reviewed
Feb 3, 2025
Abe27342
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change follows the same pattern used for merge tree to export test only utilities from the map package. The utilities that are exported are the base fuzz testing model for map and directory. Exporting the base model will allow their reuse in other testing contexts. In order to export these models, they have to be put into another file, fuzzUtils.ts, as exporting from a test file (
*.spec.ts) results in the test running in that file re-running where anything is imported from it, which is not something we want.The in-progress PR shows the expected usages of these imports: #23701