Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(client-presence): Unit tests for 'workspaceActivated' event #23809

Merged
merged 10 commits into from
Feb 12, 2025
Merged

test(client-presence): Unit tests for 'workspaceActivated' event #23809

merged 10 commits into from
Feb 12, 2025

Conversation

WillieHabi
Copy link
Contributor

@WillieHabi WillieHabi commented Feb 6, 2025 •
edited
Loading

Description

Tests for implementing workspaceActivated event.

Presence
  protocol handling
    receiving DatastoreUpdate
        - with unregistered States workspace emits 'workspaceActivated'
        - with unregistered Notifications workspace 'workspaceActivated'
        - with unregistered workspace of unknown type emits 'workspaceActivated'
        - with registered workspace does NOT emit 'workspaceActivated'

Fixes AB#29541

@github-actions github-actions bot added base: main PRs targeted against main branch area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct labels Feb 6, 2025
@WillieHabi WillieHabi marked this pull request as ready for review February 7, 2025 17:07
Copilot
Copilot AI reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

packages/framework/presence/src/test/presenceDatastoreManager.spec.ts Outdated Show resolved Hide resolved
packages/framework/presence/src/test/presenceDatastoreManager.spec.ts Outdated Show resolved Hide resolved
Copilot
Copilot AI reviewed Feb 11, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
jason-ha
jason-ha reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@jason-ha jason-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to update description if test case descriptions are updated.

packages/framework/presence/src/test/presenceDatastoreManager.spec.ts Outdated Show resolved Hide resolved
packages/framework/presence/src/test/presenceDatastoreManager.spec.ts Outdated Show resolved Hide resolved
packages/framework/presence/src/test/presenceDatastoreManager.spec.ts Outdated Show resolved Hide resolved
packages/framework/presence/src/test/presenceDatastoreManager.spec.ts Outdated Show resolved Hide resolved
packages/framework/presence/src/test/presenceDatastoreManager.spec.ts Show resolved Hide resolved
packages/framework/presence/src/test/presenceDatastoreManager.spec.ts Outdated Show resolved Hide resolved
jason-ha
jason-ha reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@jason-ha jason-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to update PR description

packages/framework/presence/src/test/presenceDatastoreManager.spec.ts Outdated Show resolved Hide resolved
packages/framework/presence/src/test/presenceDatastoreManager.spec.ts Show resolved Hide resolved
@WillieHabi WillieHabi merged commit afe8177 into microsoft:main Feb 12, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@jason-ha jason-ha jason-ha approved these changes

@tylerbutler tylerbutler Awaiting requested review from tylerbutler

Assignees
No one assigned
Labels
area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WillieHabi @jason-ha